Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@adangel
Copy link
Member

@adangel adangel commented Jan 31, 2025

Describe the PR

While release, I've seen the following warnings:

[DEPRECATION] Template.register_filter is deprecated. Use Environment#register_filter instead. Called from /home/andreas/PMD/source/pmd/docs/_plugins/custom_filters.rb:136:in `<top (required)>'
[DEPRECATION] Template.register_tag is deprecated. Use Environment#register_tag instead. Called from /home/andreas/PMD/source/pmd/docs/_plugins/details_block.rb:22:in `<top (required)>'

The reason is, that we use in our toplevel Gemfile already liquid 5.x, but in docs/Gemfile we still use liquid 4.x. We also can't just update to liquid 5 everywhere, as jekyll still uses liquid 4.
Furthermore, the pmdtester uses liquid 5 already.

I've cleaned up a bit, how we call render_release_notes.rb, so that we call it within the docs directory. Then we can reuse the Gemfile from docs rather than using a group.

The toplevel Gemfile is then only used for Danger and pmdtester.

Related issues

  • Fix #

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

Then we can reuse the Gemfile from docs rather than
using a group.
@adangel adangel added the in:pmd-internals Affects PMD's internals label Jan 31, 2025
@adangel adangel added this to the 7.11.0 milestone Jan 31, 2025
@ghost
Copy link

ghost commented Jan 31, 2025

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@jsotuyod jsotuyod merged commit b013853 into pmd:main Jan 31, 2025
3 checks passed
@adangel adangel deleted the doc-render-release-notes branch February 1, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:pmd-internals Affects PMD's internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants