-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[apex] New rule NcssCount to replace old Ncss*Count rules #6198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove now deprecated rules.
The node ASTStatement is not used and doesn't appear in the tree.
Contributor
|
Compared to main: (comment created at 2025-11-13 15:07:51+00:00 for 50b368f) |
Use the same limits as the old rules. NcssMethodCount used 40, NcssTypeCount used 500. Note: ExcessiveClassLength used 1000 and NcssConstructorCount used 20.
adangel
commented
Nov 7, 2025
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/metrics/ApexMetrics.java
Show resolved
Hide resolved
adangel
commented
Nov 13, 2025
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/design/NcssCountRule.java
Outdated
Show resolved
Hide resolved
adangel
commented
Nov 13, 2025
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/design/NcssCountRule.java
Outdated
Show resolved
Hide resolved
10 tasks
adangel
commented
Nov 13, 2025
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/design/NcssTypeCountRule.java
Show resolved
Hide resolved
Member
Author
|
I'm going to merge this for 7.19.0, assuming this is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a:new-rule
Proposal to add a new built-in rule
is:deprecation
The main focus is deprecating public APIs or rules, eg to make them internal, or removing them
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)