Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[java] Fix #6188: UnitTestsShouldIncludeAssert - FP when TestNG @Test.expectedException is present #6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adangel merged 1 commit into from
Nov 25, 2025
Merged

[java] Fix #6188: UnitTestsShouldIncludeAssert - FP when TestNG @Test.expectedException is present #6202

adangel merged 1 commit into from
Nov 25, 2025

Conversation

@lukasgraef
Copy link
Contributor

@lukasgraef lukasgraef commented Nov 3, 2025 •
edited
Loading

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@lukasgraef lukasgraef marked this pull request as ready for review November 3, 2025 21:14
@pmd-actions-helper
Copy link
Contributor

pmd-actions-helper bot commented Nov 3, 2025 •
edited
Loading

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 6 violations, 0 errors and 0 configuration errors.

Regression Tester Report

(comment created at 2025-11-03 22:18:17+00:00 for 99fa082)

@lukasgraef lukasgraef changed the title [java] Fix #6188: JUnitTestsShouldIncludeAssert - FP when TestNG @Test.expectedException is present [java] Fix #6188: UnitTestsShouldIncludeAssert - FP when TestNG @Test.expectedException is present Nov 3, 2025
@adangel adangel self-requested a review November 24, 2025 17:07
adangel
adangel approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel self-assigned this Nov 25, 2025
@adangel adangel added this to the 7.19.0 milestone Nov 25, 2025
@adangel adangel merged commit 99fa082 into pmd:main Nov 25, 2025
12 checks passed
adangel added a commit that referenced this pull request Nov 25, 2025
@adangel
[doc] Update release notes (#6188, #6202)
dca9c00
adangel added a commit that referenced this pull request Nov 25, 2025
@adangel
[java] Fix #6188: UnitTestsShouldIncludeAssert - FP when TestNG @Test…
8d2b619 
….expectedException is present (#6202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adangel adangel adangel approved these changes

Assignees

@adangel adangel

Labels

None yet

Projects

None yet

Milestone

7.19.0

Development

Successfully merging this pull request may close these issues.

[java] UnitTestShouldIncludeAssert false positive when TestNG @Test.expectedException present

2 participants

@lukasgraef @adangel