BorringSSL Fork #2342
Open
BorringSSL Fork #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-f
requested changes
May 21, 2018
Crypto/src/CipherKeyImpl.cpp
Outdated
| case EVP_CIPH_CCM_MODE: | ||
| return MODE_CCM; | ||
| //Changed for port OpenSSL -> BoringSSL | ||
| #if defined(OPENSSL_IS_BORINGSSL) |
| throw NotImplementedException(); | ||
| #else | ||
| std::string friendlyName; | ||
| f(pCert) |
| //Changed for port OpenSSL -> BoringSSL | ||
| #if defined(OPENSSL_IS_BORINGSSL) | ||
| dh->p = BN_bin2bn(dh1024_p, sizeof(dh1024_p), 0); | ||
| dh->g = BN_bin2bn(dh1024_g, sizeof(dh1024_g), 0); |
There was a problem hiding this comment.
no need to set dh->length here?
|
Please re-target pull request against poco-1.10.0 branch. |
|
@matejk not urgent, put on TODO list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are changes necessary to build Poco Library with BoringSSL instead of OpenSSL.
I tested that it's works on MacOs.