Use @lit-labs/react #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#34 The existing glue code was working okay. However, adding property or attribute to the element is daunting and easy to misconfigure. I replaced the code with new integration package provided by official lit maintainers for maintanability reasons. I kept type signatures to make sure this change does not break users' type checking accidentally. close #34
Contributor
|
Heya this PR is looking great so far! Is there anything I can do to help, or is there anything you'd need changed / fixed from the Lit side? |
Owner
Author
|
@e111077 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34
The existing glue code was working okay. However, adding property or attribute to the element is daunting and easy to misconfigure. I replaced the code with the new integration package provided by official lit maintainers for maintainability reasons.
I kept type signatures to make sure this change does not break users' type checking accidentally.