remove copy-to-clipboard #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for your contribution. I confirmed the Safari bug then opened a new issue (#37 ). |
11 tasks
pocka
added a commit
to pocka/figspec-react
that referenced
this pull request
Oct 16, 2022
storybookjs/addon-designs#161 (comment) In order to avoid importing `copy-to-clipboard` package, which was [removed](pocka/figspec#36) at v1.0.1. That package is written CJS so v1.0.0 ESM build does not work at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I was trying to import this using a CDN and native ES Modules, but then I ran into the issue that this package's ESM build uses
copy-to-clipboardwhich is written in CJS. This means when you try to load this package, it throws an error incopy-to-clipboardthatrequireis not defined.Changes
I've replaced
copy-to-clipboardwith the native clipboard api. Browser compatibility can be found here.This should allow using this package with just:
import "https://unpkg.com/@figspec/components?module"Testing
I was able to test this manually in Chrome and Firefox with the
storybookcommand.Safari did not allow me to click on anything and bring up the inspector view. Not sure why. But, i ran the
copyfunction separately in another window and it copied correctly.