Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@BurnWW
Copy link
Contributor

@BurnWW BurnWW commented Feb 3, 2025

No description provided.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering just needs to be fixed in the config file. Via the failed test

@BurnWW
Copy link
Contributor Author

BurnWW commented Feb 3, 2025

The ordering just needs to be fixed in the config file. Via the failed test

I have already adjusted the order of config.

@BurnWW BurnWW requested a review from TarikGul February 3, 2025 05:29
@TarikGul
Copy link
Member

TarikGul commented Feb 3, 2025

Still an issue, you can run yarn test locally to ensure you have it right

@BurnWW
Copy link
Contributor Author

BurnWW commented Feb 3, 2025

@TarikGul I am very sorry, I misunderstood the sorting rule. I realized it should be sorted by the first letter through studying the test code. I have already modified it and completed yarn test.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Thanks 👍

@TarikGul TarikGul merged commit fa07a46 into polkadot-js:master Feb 3, 2025
5 checks passed
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants