Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feedback/#11253 #11304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Apr 3, 2025
Merged

Feedback/#11253 #11304

merged 22 commits into from
Apr 3, 2025

Conversation

@piggydoughnut
Copy link
Contributor

@piggydoughnut piggydoughnut commented Feb 17, 2025 •
edited
Loading

Addressing feedback from #11253 and a few points from #11262 (comment)

changes

  • fixed issue with start and end dates on workload and workplans being the same (Coretime page is very confusing #11253 (comment)) (Coretime Chain -> Coretime )
  • on Coretime Chain -> filter by parachain id in both workload and workplan, so users can see where is their chain scheduled in the future
  • changed cycle progress componenet to show countdown -> now you can see both countdown in time and timeslice progress with a pie chart (Relay chain -> Coretime -> Overview)
  • Sale tab - showing start price of the sale in the Overview
  • Sale tab - always showing price even if the cores are sold out
  • Sale tab - sale history - fix for the dates for the Fixed price period (currently fixed price period has same start and end date)
    to reproduce:
    • Go to Sale tab under Coretime on Relay chain
    • Choose sale number in the select at the bottom
    • Look at the last table on the left which is called Fixed price Phase (start and end should be 1 week apart)

minor code changes

  • renamed chainName to relayName

@piggydoughnut piggydoughnut marked this pull request as draft February 17, 2025 07:58
@piggydoughnut piggydoughnut mentioned this pull request Mar 4, 2025
Closed
@piggydoughnut piggydoughnut marked this pull request as ready for review March 5, 2025 06:38
ap211unitech
ap211unitech reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@ap211unitech ap211unitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks great to me 🚀
Just have a couple of questions and suggestions.

@ap211unitech
Copy link
Member

@piggydoughnut ping :)

@piggydoughnut
Copy link
Contributor Author

piggydoughnut commented Apr 2, 2025 •
edited
Loading

@ap211unitech Appologies for such a delay, I got distracted by another project. I have already blocked time this month to work on the issues that are assigned to me at pjs/apps :) Starting with finishing this PR. Thanks for your patience :) heh

@piggydoughnut
Copy link
Contributor Author

Also added a renewal link for RegionX for the cores which are in potential renewals list

@ap211unitech
Copy link
Member

Perfect 👌. Thanks @piggydoughnut.

@piggydoughnut piggydoughnut merged commit 468a3d5 into master Apr 3, 2025
5 checks passed
@piggydoughnut piggydoughnut deleted the feedback/#11253 branch April 3, 2025 23:01
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ap211unitech ap211unitech ap211unitech approved these changes

@TarikGul TarikGul Awaiting requested review from TarikGul

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piggydoughnut @ap211unitech @polkadot-js-bot