FIX: Unwanted Errors on Sudo Page When Submitting Calls #11426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinfernandez1
approved these changes
Mar 27, 2025
MOZGIII
reviewed
Mar 28, 2025
| <StyledSection className={className}> | ||
| <Extrinsic | ||
| defaultValue={apiDefaultTxSudo} | ||
| defaultValue={withWeight ? api.tx.sudo.sudoUncheckedWeight : api.tx.sudo.sudo} |
There was a problem hiding this comment.
This causes state loss when the weight override is toggled. Please fix.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The Sudo page sometimes returns unexpected errors when submitting a call. However, the same action works correctly when performed from the Extrinsics page.
To resolve this issue, we are aligning the Sudo page's submission behavior with the Extrinsics page, which functions correctly. This involves analyzing the working implementation on the Extrinsics page and applying the necessary adjustments to the Sudo page.
This fix ensures a more consistent and error-free experience when submitting calls via the Sudo page.
🤔 Previous Behaviour
Screen.Recording.2025-03-26.at.12.44.34.mov
✅ Current Behaviour
Screen.Recording.2025-03-26.at.12.47.04.mov