fix: filter-out non eth accounts from eth chains #11877
Conversation
There was a problem hiding this comment.
Nice fix 👍 Thanks for the explanation.
Leaky abstractions: UI context, ui-keyring, and keyring each make assumptions about type and “what the chain supports,” but there’s no single contract that all layers share. The behavior depends on who supplies type and when exceptions happen to bubble up.
This bit you wrote really resonates with me.
I've put an extra commit to leave the ctx type as it was... Just in case. I'm pretty sure that it's only used as a fallback mechanism, when the type of the account is not provided, but who knows, right? So, anyways, just in case, I left that part untouched.
I swear that when I first saw the commit the OP pointed as the culprit of the issue I thought: "yeah, no, this can't be it... there must be some other commit that he skipped or something", boy, was I wrong... |
|
Thanks @josepot for quick fix |
No worries! Thanks for the quick merge! Since this is a rather serious problem, may I request for a prompt hot-fix release? 🙏 |
|
Certainly! I’ll look into where we can apply the fix to get this flow working correctly. |
What's wrong with the hot-fix of this PR? Again, it's not meant to fix the architectural issues, it's just meant to get us out of this pickle. Is there a reason why you think that this PR doesn't do the trick? Could you please elaborate? |
|
If I remember correctly the fix should be live in https://polkadot.js.org/apps/#/explorer based on how the CI does releases per PR (since its considered the dev env). The only thing that needs to get released next is the IPFS version which requires an actual manual release of |
Apologies for the confusion. I assumed you were referring to fixing the architectural issues. Also, its already live now on https://polkadot.js.org/apps/#/explorer |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #11875 . I already provided an explanation of the cause in the issue.