Config value #3033
Open
Config value #3033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3033 +/- ##
==========================================
+ Coverage 12.69% 15.24% +2.54%
==========================================
Files 160 160
Lines 12533 12760 +227
==========================================
+ Hits 1591 1945 +354
+ Misses 10942 10815 -127
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
This looks very promising :D I unfortunately don't really have time to review this right now, any spare time I have, I want to put into finishing the next release. But in general, I very much agree with the concept of giving modules a view of their own section without them having to select their section every time And of course the testing infrastructure will also be very useful ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR introduces the
config::valuetype and use it all over polybar.Instead of reading configuration values from concatenation of string keys to form the whole key,
config::valueprovides a[]operator used to compose new keys.Related Issues & Documents
This is a preliminary refactor towards a new configuration format and #2391
Documentation (check all applicable)