Differentiability of hyperelastic periodic simulation (homogenization) #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 70.24% 70.60% +0.35%
==========================================
Files 333 335 +2
Lines 38013 38261 +248
Branches 5667 5708 +41
==========================================
+ Hits 26703 27013 +310
+ Misses 11310 11248 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
teseoch
approved these changes
Oct 9, 2024
| // assert(mesh->in_ordered_vertices_[1] == 1); | ||
| // assert(mesh->in_ordered_vertices_[2] == 2); | ||
| // assert(mesh->in_ordered_vertices_[mesh->in_ordered_vertices_.size() - 1] == vertices.rows() - 1); | ||
| std::sort(tmp.begin(), tmp.end()); |
Contributor
Author
There was a problem hiding this comment.
This is only spacing...Should I revert it?
|
|
||
| void VariableToSimulation::set_output_indexing(const json &args) | ||
| { | ||
| const std::string composite_map_type = args["composite_map_type"]; |
Contributor
Author
There was a problem hiding this comment.
This is moving around the inverse optimization code, the branching was ugly so I moved into each derived class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.