Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@SeanTAllen
Copy link
Member

Because the tests were public, if they didn't compile, apps and libaries
that depend upon appdirs like ponyup would fail to build.

@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - changed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 32.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen force-pushed the dont-export-tests branch from 67323af to 01756a3 Compare May 7, 2021 02:28
Because the tests were public, if they didn't compile, apps and libaries
that depend upon appdirs like ponyup would fail to build.
@SeanTAllen
Copy link
Member Author

@ergl this is why we had to rev ponyup even though the only fix was in tests. once this is merged, we can do another release and it won't impact anything else going forward.

@ergl
Copy link
Contributor

ergl commented May 7, 2021

@SeanTAllen I see, good catch!

@SeanTAllen SeanTAllen merged commit 9bd1217 into main May 7, 2021
@SeanTAllen SeanTAllen deleted the dont-export-tests branch May 7, 2021 11:33
@SeanTAllen
Copy link
Member Author

@ergl well, i really never caught it until it was staring me in the face.

github-actions bot pushed a commit that referenced this pull request May 7, 2021
github-actions bot pushed a commit that referenced this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants