Files that changed from the base of the PR and between 0341df4 and ea6eb43.

• liblwgeom/liblwgeom_internal.h (1 hunks)
• liblwgeom/lwgeom_geos.h (1 hunks)
• liblwgeom/lwgeom_log.h (3 hunks)
• postgis/geography_centroid.c (1 hunks)
• postgis/geography_measurement.c (1 hunks)
• postgis/lwgeom_functions_basic.c (1 hunks)
• postgis/lwgeom_spheroid.c (1 hunks)

• postgis/geography_centroid.c
• postgis/geography_measurement.c

liblwgeom/lwgeom_geos.h (1)

28-32: LGTM! The conditional attribute improves error detection.

The use of __attribute__ (( format(printf, 1, 0) )) within the #ifdef __GNUC__ block ensures compile-time format string checks with GCC, enhancing type safety and reliability.

liblwgeom/lwgeom_log.h (3)

129-133: LGTM! The conditional attribute improves error detection.

The use of __attribute__ ((format (printf, 1, 2))) within the #ifdef __GNUC__ block ensures compile-time format string checks with GCC, enhancing type safety and reliability.

---

143-147: LGTM! The conditional attribute improves error detection.

The use of __attribute__ ((format (printf, 1, 2))) within the #ifdef __GNUC__ block ensures compile-time format string checks with GCC, enhancing type safety and reliability.

---

156-160: LGTM! The conditional attribute improves error detection.

The use of __attribute__ ((format (printf, 2, 3))) within the #ifdef __GNUC__ block ensures compile-time format string checks with GCC, enhancing type safety and reliability.

postgis/lwgeom_spheroid.c (1)

28-30: LGTM! The preprocessor directive ensures compatibility with MSVC.

Defining _USE_MATH_DEFINES and including <math.h> ensures that mathematical constants are available when compiling with Microsoft Visual Studio, enhancing cross-platform compatibility.

liblwgeom/liblwgeom_internal.h (1)

44-46: LGTM! The preprocessor directive ensures compatibility with MSVC.

Defining _USE_MATH_DEFINES and including <math.h> ensures that mathematical constants are available when compiling with Microsoft Visual Studio, enhancing cross-platform compatibility.

postgis/lwgeom_functions_basic.c (1)

38-42: Ensure compatibility with other compilers.

The changes introduce a preprocessor directive for _MSC_VER to define _USE_MATH_DEFINES and include the <math.h> header to ensure mathematical constants are defined when compiling with Microsoft Visual Studio. The order of header inclusions has been adjusted accordingly.

However, ensure that these changes do not affect compatibility with other compilers.

Verification successful

---

Ensure compatibility with other compilers.

The changes introduce a preprocessor directive for _MSC_VER to define _USE_MATH_DEFINES and include the <math.h> header to ensure mathematical constants are defined when compiling with Microsoft Visual Studio. The order of header inclusions has been adjusted accordingly. The presence of conditional compilation blocks indicates that these changes should not affect compatibility with other compilers.

• The _MSC_VER directive is only active when compiling with Microsoft Visual Studio.
• Existing directives handle GCC-specific warnings.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility with other compilers.

# Test: Compile the code with different compilers and verify no errors.
# Expect: No compilation errors.

# Check for GCC
gcc -c postgis/lwgeom_functions_basic.c

# Check for Clang
clang -c postgis/lwgeom_functions_basic.c

# Check for MSVC (simulated)
# Note: MSVC cannot be directly tested in this environment.
echo "Simulate MSVC compilation check"

Length of output: 303

---

Script:

#!/bin/bash
# Search for preprocessor directives and conditional compilation blocks in the file.
ast-grep --lang c --pattern $'#ifdef $_
$$$
#endif' postgis/lwgeom_functions_basic.c

Length of output: 85

---

Script:

#!/bin/bash
# Search for all preprocessor directives in the file.
rg '^#' postgis/lwgeom_functions_basic.c -A 2

Length of output: 872