Upgrade to stb_image v2.19 #41
Conversation
|
Nice, thanks! Do you think you could add back ico support (#24), it seems to be removed right now. |
|
The patch just replaces the new stb_image.h and fixes some incompatible API usage with default arguments. Sorry for not validating more. I will try to resolve it later this weekend. |
|
ok, thanks! |
|
Hi @posva , I have made two additional commits in this pull request. Now it works on gif and ico. Could you look over them? I have no knowledge about any image file format. |
|
Hey, it still doesn't work with GIFs |
|
Hi, I am sorry for not testing the patch with multi-frame gifs. I reverted the previous patch on gif and made a new commit. The crash seems to be fixed by the new patch (3fa8440). Thanks. |
|
@posva Hi! Do you mind tagging a new release now that this is fixed? thanks! |
|
Done, If someone could create the PRs to homebrew that would be perfect. Otherwise I will do in Xmas |
This fixes the following issue: #34 #38 #36 #37 #39.
#40 turns out to be a heap-use-after-free error. Please review the usage of the following two API from stb.
stbi__gif_load_nextstbi__load_main