upgrade to react 15 and router v2 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able a side of snaps if you only want a menu on each side
…ties where it needs to go
… in props anymore. this.context.router is used or react-router browserHistory
… use componentWillUnmount instead otherwise react-router complains about set multiple leave hooks to the same route.
…o feature branch and reverted location to contextTypes instead of props.
|
Looking good guys! Publishing to NPM shortly |
|
Fixed issue #28 with this pull request |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pors Merged John's commits into the feature branch and fixed a couple of things there.
Please review and test in mobile