-
Couldn't load subscription status.
- Fork 7
Snapshotter identity check #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to testnet_pretask
… reduce default rpc polling interval to 10 seconds
…r_id_check Testnet pretask: snapshotter id check
…ve default values
xadahiya
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on one of the staging instances, running as expected without any issues. Approving!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44 powerloom/deploy#20
Checklist
Current behaviour
Described in #44
New expected behaviour
During startup, do a sanity check and exit with an error code 1, if the configured snapshotter identity us not found on the protocol smart contract as an allowed snapshotter
Do not process epochs and build snapshots, aggregates if snapshotter is found to be inactive
When a snapshotter updated event is detected on the protocol state contract, check against current snapshotter's identity
Change logs
Added
Deployment Instructions
NA