Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@anomit
Copy link
Member

@anomit anomit commented Sep 5, 2023

Fixes #44 powerloom/deploy#20

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.8.0 and above.
  • I ran pre-commit checks against my changes.
  • I've written tests against my changes and all the current present tests are passing.

Current behaviour

Described in #44

New expected behaviour

  • During startup, do a sanity check and exit with an error code 1, if the configured snapshotter identity us not found on the protocol smart contract as an allowed snapshotter

  • Do not process epochs and build snapshots, aggregates if snapshotter is found to be inactive

  • When a snapshotter updated event is detected on the protocol state contract, check against current snapshotter's identity

Change logs

Added

  • Startup check whether current snapshotter's identity is allowed on the protocol state contract
  • Runtime check if the current snapshotter's identity is deactivated/disallowed on the protocol state contract

Deployment Instructions

NA

@anomit anomit requested a review from xadahiya September 5, 2023 07:52
@anomit anomit self-assigned this Sep 5, 2023
@anomit anomit linked an issue Sep 5, 2023 that may be closed by this pull request
@anomit anomit marked this pull request as ready for review September 5, 2023 17:52
Copy link
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on one of the staging instances, running as expected without any issues. Approving!

@xadahiya xadahiya merged commit 0e65170 into main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strick check on snapshotter identity on protocol state contract

4 participants