Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore/faster aggregation based on SnapshotSubmitted events #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 13, 2023
Merged

Chore/faster aggregation based on SnapshotSubmitted events #33

merged 8 commits into from
Jun 13, 2023

Conversation

@xadahiya
Copy link
Member

@xadahiya xadahiya commented Jun 13, 2023 •
edited
Loading

Fixes #32

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.8.0 and above.
  • I ran pre-commit checks against my changes.

Current behaviour

Right now, since aggregation calculation depends on underlying snapshots to get finalized, this leads to a longer wait time for aggregation calculations to finish.

New expected behaviour

Instead of relying on the SnapshotFinalized event, snapshotters should be designed to wait for the SnapshotSubmitted event associated with their specific address. This modification will enable snapshotters to proceed with the necessary calculations promptly.

Change logs

Changed

  • Aggregate calculations are now triggered on SnapshotSubmitted event from snapshotter instead of SnapshotFinalized event.
  • README updates
  • Increase Core API rate limits

Deployment Instructions

No change

@xadahiya xadahiya requested a review from anomit June 13, 2023 07:30
anomit
anomit approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@anomit anomit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed to be running stably on staging instances

@xadahiya xadahiya merged commit 19eb2ed into onchain_pooler Jun 13, 2023
This was referenced Jun 13, 2023
Merged
Closed
@SwaroopH SwaroopH deleted the chore/faster_aggregation_based_on_local_data branch July 27, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anomit anomit anomit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xadahiya @anomit