fix: fetch last finalized epoch ID for project from protocol state contract #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xadahiya
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
Checklist
Current behaviour
During a fresh run of a node, before the local services receive their first snapshot finalization event for a project, the same project's query for last finalized epoch ID on
core_api.pywould fail.New expected behaviour
This fix ensure even if a loally cached state is not available for project's finalized epoch ID,
core_apican consult last finalized status from the protocol state contract.Change logs
Fixed
Request handler:
https://github.com/PowerLoom/pooler/blob/03302099be391f4637d7a22b9eab45473c4758e4/pooler/core_api.py#L186
Fetch from protocol state contract:
https://github.com/PowerLoom/pooler/blob/03302099be391f4637d7a22b9eab45473c4758e4/pooler/core_api.py#L212-L238
Deployment Instructions
Restart
gunicorn_core_launcher.py