Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Protecting multiple trigger on same instance by heritage #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/2.x
Choose a base branch
from
Open

Protecting multiple trigger on same instance by heritage #1084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...-junit4/src/main/java/org/powermock/modules/junit4/internal/impl/NotificationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,10 @@ void testStartHasBeenFired(Description d) {
}

void testInstanceCreated(Object newTestInstance) {
// Prevent double trigger on same instance
if (currentTestInstance == newTestInstance) {
return;
}
switch (behaviour) {
case PENDING:
behaviour = DetectedTestRunBehaviour.TEST_INSTANCE_CREATED_FIRST;
Expand Down
4 changes: 4 additions & 0 deletions tests/mockito/junit4/src/test/java/samples/powermockito/junit4/bugs/github660/AClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package samples.powermockito.junit4.bugs.github660;

public class AClass {
}
32 changes: 32 additions & 0 deletions tests/mockito/junit4/src/test/java/samples/powermockito/junit4/bugs/github660/ChildTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package samples.powermockito.junit4.bugs.github660;


import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.mockito.Mockito;
import org.powermock.modules.junit4.PowerMockRunner;
import org.powermock.modules.junit4.PowerMockRunnerDelegate;

import java.io.PrintStream;

public class ChildTest extends ParentTest{

protected PrintStream outMock;

public ChildTest(){
super();
outMock = Mockito.mock(PrintStream.class);
System.setErr(outMock);

}
@Test
public void test_A(){
Mockito.verify(outMock,Mockito.times(0)).println("Notifications are not supported when all test-instances are created first!");
}

@Test
public void test_B(){
Mockito.verify(outMock,Mockito.times(0)).println("Notifications are not supported when all test-instances are created first!");
}
}
20 changes: 20 additions & 0 deletions ...s/mockito/junit4/src/test/java/samples/powermockito/junit4/bugs/github660/ParentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package samples.powermockito.junit4.bugs.github660;

import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.BlockJUnit4ClassRunner;
import org.mockito.Mockito;
import org.powermock.core.classloader.annotations.PrepareForTest;
import org.powermock.modules.junit4.PowerMockRunner;
import org.powermock.modules.junit4.PowerMockRunnerDelegate;

import java.io.PrintStream;

@RunWith(PowerMockRunner.class)
@PowerMockRunnerDelegate(BlockJUnit4ClassRunner.class)
@PrepareForTest(AClass.class)
@Ignore
public class ParentTest {

}