feat: Split FigletInterface to allow fine grained use of concerns #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @povils,
I stumbled upon your project which I find really cool because I LOOOOOVE PHP. You made an implementation of figlet in php. Cool. Just adding my 2 cents to attempt to improve it a little more. Will make other pull requests soon. Still working on it locally. Nice work you did. Just trying to help. Not to be the "smart guy" or even worse the "annoying pedantic nerd". I just want to share back what I tried to do with your cool work. Thanks again for making this.