Chore/Cleanup #190
Merged
Chore/Cleanup #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgzonArifi
requested changes
Sep 26, 2023
Lingua-App/Lingua/Lingua/Scenes/ProjectFormView/ProjectFormView.swift
Outdated
Show resolved
Hide resolved
EgzonArifi
reviewed
Sep 27, 2023
| isValid: $sheetIdValid | ||
| ) | ||
| }) { | ||
| Text(.init(Lingua.ProjectForm.sheetIdHelp)).padding() |
There was a problem hiding this comment.
@borut-t The links are broken since with this initializer, SwiftUI handles localized strings differently, enabling certain features like link detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done some minor code and project cleanup. One issue still persist, and that is localizing currently selected project with keyboard shortcuts. For some reason it always picks up the same.