Gracefully handle missing user in channels#7504
Merged
nanaya merged 4 commits intoppy:masterfrom Apr 20, 2021
Merged
Conversation
top center is also already tooltip position default
nanaya
requested changes
Apr 19, 2021
| return ( | ||
| <div className={className}> | ||
| <div className='chat-message-group__sender'> | ||
| <a className='js-usercard' data-tooltip-position='top center' data-user-id={sender.id} href={route('users.show', { user: sender.id })}> |
Collaborator
There was a problem hiding this comment.
apparently the tooltip-position is supposed to work except it's not anymore when it's converted to typescript. Should probably at least keep the parameter intact for when it's supported again.
also top center is not the default for user card. It's hardcoded to right center at the moment which is the original default.
nanaya
approved these changes
Apr 20, 2021
Collaborator
nanaya
left a comment
There was a problem hiding this comment.
Not sure about link without href but should do for now I guess 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of everything just erroring.
Also, finally removes chat's custom user link rendering.
(and fixes usercard missing tooltip position)