Restructure rooms listing #8635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
reviewed
Feb 16, 2022
Collaborator
notbakaneko
left a comment
There was a problem hiding this comment.
The user playlist and multiplayer history pages could probably make use of difficulty_range too since all it uses the beatmaps for is the difficulty and cover image of the first one 🤔
Collaborator
Author
|
Cover url is still needed for those pages so it's not as useful there (and more changes are needed to be able to remove the include there). |
notbakaneko
requested changes
Feb 17, 2022
notbakaneko
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes beatmap include and adds
difficulty_range.minanddifficulty_range.max🤔...when
x-api-version: 20220215is specified on the header.