Add per-mod settings #6432
Merged
Add per-mod settings #6432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can the customization overlay not hit the bottom area of the mod select overlay (where the mod buttons are), it's darkening the score multiplier text. |
frenzibyte
requested changes
Oct 8, 2019
Member
|
This is missing any form of testing. How are you testing? Please make a test scene with a test mod which implements settings. |
Member
|
Just a heads up that whatever you did to this PR to bring it up-to-date is not the correct way ( |
Member
|
Updated behaviour somewhat to use new logic in #7081. |
huoyaoyuan
reviewed
Dec 6, 2019
1 task
smoogipoo
requested changes
Dec 9, 2019
4 tasks
smoogipoo
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6272 and in turn allows #4391, #4175, and #3201 to be realized.
Creates a new interface
IModHasSettingswhich allows a mod to create controls such as check boxes and sliders to allow the user control over it's properties.A new button is found on
ModSelectOverlaycalled "Customization" which opens a simple interface where all controls for customizing mods are found.The Modify mod will be made in a separate PR and is only shown here as an example.
Example:
