Move difficulty calculation fields from Slider to OsuDifficultyHitObject
#32410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
!diffcalc |
|
Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/13886809756 |
|
Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/13886809756 |
|
Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/13886809756 |
Member
Author
|
!diffcalc |
tsunyoku
approved these changes
Apr 9, 2025
Finadoggie
pushed a commit
to Finadoggie/osu
that referenced
this pull request
Aug 18, 2025
…Object` (ppy#32410) * Move difficulty calculation fields from `Slider` to `OsuDifficultyHitObject` * Remove redundant check * Use `LastObject` where possible * Update tests * Make `LazyTravelDistance` `double` --------- Co-authored-by: James Wilson <[email protected]>
This was referenced Oct 29, 2025
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slider-related diffcalc fields being in the slider hitobject itself while being set and used exclusively in diffcalc always annoyed me. This moves them to where they should be.
There are some tiny differences in difficulty values which
I'm not really sure what to attribute tois probably related to the fact that we don't calculate slider distance for the second beatmap object now, but they're tiny enough to consider a non-issue in my opinion