Implement difficulty evaluators in the osu! mania ruleset #33411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abraker95
suggested changes
Jun 11, 2025
abraker95
left a comment
There was a problem hiding this comment.
Mostly ok, just a few minor things
osu.Game.Rulesets.Mania/Difficulty/Evaluators/IndividualStrainEvaluator.cs
Outdated
Show resolved
Hide resolved
abraker95
suggested changes
Jun 12, 2025
abraker95
approved these changes
Jun 14, 2025
abraker95
left a comment
There was a problem hiding this comment.
Don't see any more missing parts 👍
Member
|
!diffcalc |
stanriders
approved these changes
Jun 27, 2025
tsunyoku
approved these changes
Jun 27, 2025
Finadoggie
pushed a commit
to Finadoggie/osu
that referenced
this pull request
Aug 18, 2025
* stuff * Implement evaluators * Typo * Fixes * clarifying comment * Fix CalculateInitialStrain * Remove debug line * Small code quality fix * Address comments, slight code quality fixes * Change comment for clarity --------- Co-authored-by: StanR <[email protected]>
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's possible and matches convention with other modes (excluding catch), I've gone ahead and taken the time to implement mania difficulty calculation evaluators in order to compartmentalize the strain skill a bit, and really show just how barebones mania calculation currently is. Values should match live.
This change should facilitate a lot of further changes to mania star rating, which I'm excited to see.