osu!taiko simplify pp summing and make performance attributes accurate #33500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lawtrohux
approved these changes
Jun 6, 2025
Member
Lawtrohux
left a comment
There was a problem hiding this comment.
as discussed, happy with the changes. once we get everything in we can start balancing, however values look good with and without.
stanriders
approved these changes
Jun 8, 2025
Finadoggie
pushed a commit
to Finadoggie/osu
that referenced
this pull request
Aug 18, 2025
ppy#33500) * Change pp summing and adjust multipliers * Add back convert consideration for hidden * And the other one whoops --------- Co-authored-by: StanR <[email protected]>
This was referenced Oct 29, 2025
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the
(diff^1.1 + acc^1.1)^1/1.1formula applied to pp with simplydiff+acc, adjusting multipliers for minimal value changes. Taiko's acc values being lower than difficulty on every single play bar a few exceptions means that all this formula did was make acc have even less of an effect on a play's total pp. This is another step towards the larger acc rebalance we have planned for next deploy. Multipliers have also been moved around so that theDifficultyandAccuracyperformance attributes always add up to makeTotal. The approved but not yet merged change to remove multipliers to the Easy mod is also included, hope that doesn't cause trouble merging this