osu!taiko consistency factor changes using object strains #34327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ppy/pp-maintainers could we please get a sheet for this? |
|
!diffcalc |
|
looks right to me |
tsunyoku
approved these changes
Jul 28, 2025
Finadoggie
pushed a commit
to Finadoggie/osu
that referenced
this pull request
Aug 18, 2025
* Calculate consistency factor from object strains * Use `totalDifficultHits` in performance calc --------- Co-authored-by: James Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With how the consistency factor is currently used, adding easy strains can nerf a map's length bonus and miss penalty. These changes fix that by calculating the consistency factor using
object strainssuch thattotal difficult hits(total hits * consistency factor) will never decrease when easy objects (outside the top 5% of object strains) are added. I factored out the peak combining code in TaikoDifficultyCalculator to avoid duplication but the diffs are really confusing, I recommend looking at the file itself if necessary. This also eliminates the need foreffectiveMissCount