Fix song select background being stuck in revealed state #34759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy#34731. The failure scenario here is as follows: - User holds down left mouse button for >200ms to reveal the background. - User presses down another mouse button and releases it in <200ms. - User releases left mouse button. Song select does not return. The timing here is key because what is happening here is that the second mouse button press is overwriting the `revealingBackground` scheduled delegate. Releasing that same mouse button within 200ms leads to that scheduled delegate being cancelled and cleared, and thus the release of left mouse wrongly decides there is nothing left to do. One thing I'm not entirely sure about is the release behaviour even with this change; as things stand, the first release of any mouse button will bring song select back, even if it was not the button that was initially held down to reveal the background. That's probably easily fixed if deemed required, but I'm most interested in fixing the bad breakage.
peppy
approved these changes
Aug 21, 2025
This was referenced Sep 4, 2025
This was referenced Oct 2, 2025
This was referenced Oct 9, 2025
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34731.
The failure scenario here is as follows:
The timing here is key because what is happening here is that the second mouse button press is overwriting the
revealingBackgroundscheduled delegate. Releasing that same mouse button within 200ms leads to that scheduled delegate being cancelled and cleared, and thus the release of left mouse wrongly decides there is nothing left to do.One thing I'm not entirely sure about is the release behaviour even with this change; as things stand, the first release of any mouse button will bring song select back, even if it was not the button that was initially held down to reveal the background. That's probably easily fixed if deemed required, but I'm most interested in fixing the bad breakage.