Add support for pinning multiplayer rooms #34764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned rooms will be used for special events such as spotlights or other ongoing featured contests and tournaments. They will be indicated by a yellow pin marker in the upper right corner of the room panel:
and shown at the top of the room listing.
As mentioned in the web-side pull, I expect that all spotlights & featured artist rooms will also be implicitly pinned. They were not until now, which meant that in a worst-case scenario that probably never happened, the client-side hack for pinning those that was used in
RoomListingup until now could fail if the rooms were not returned in the first page by osu-web (which was not guaranteed until now).Notably there's also the part wherein the game does deficient polling because it never attempts to retrieve more than the first page of active rooms, but that probably requires a significant restructuring of how the lounge screens work that I am not doing without getting explicit buy-in first.
I've already seen someone report last week that they're not able to see their friends' multiplayer rooms that could possibly be caused by that. As far as I can tell the problem is currently masked unless there are more than 250 active rooms / playlists at any point in time.
Visual adjustments to the private room marker made at @peppy's behest.