Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@genskyff
Copy link
Contributor

@genskyff genskyff commented Aug 23, 2025

Long notes are a huge part of mania gameplay, especially with all the o2jam-style maps out there. But finding LN-heavy maps is kind of a pain since beatmap tags are often missing or wrong, and some players just want to avoid LNs entirely.

The another rhythm game Quaver has this neat LN percentage filter, so I figured why not add it to osu!mania too? Now you can filter maps by how much of them are actually long notes.

output.mp4

What's new

  • Added ln/lns keywords to search - works with all the usual operators (=, !=, >=, >, <=, <)
  • Uses percentages (0-100) because that's way more intuitive than decimals
  • Examples:
    • ln=0 - maps with no long notes
    • ln>=50 - maps with 50% or more long notes
    • ln<10 - maps with less than 10% long notes
  • Added tests

Known Issues

This might not work perfectly on converted beatmaps since I'm using EndTimeObjectCount instead of actually parsing the HitObjects from the Beatmap class. But honestly, if you're hunting for LN maps you're probably not looking at converts anyway, so it should be fine for what people actually want to do.

@genskyff
Copy link
Contributor Author

CI is failing but doesn't seem to be caused by my commits.

@genskyff genskyff requested review from bdach and smoogipoo August 25, 2025 13:25
@genskyff
Copy link
Contributor Author

@bdach
Thanks for the review, I've fixed the issues mentioned above.

@genskyff genskyff requested a review from bdach August 26, 2025 12:32
@genskyff genskyff changed the title Add long note ratio filter for mania mode Add long note percentage filter for mania mode Aug 26, 2025
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess source looks fine and does what it claims to want to do

I'm going to extrapolate @peppy's thumbs up on #34774 (comment) as understanding and approval of the current limitations of this and thus I see no reason to need another approval on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants