-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add long note percentage filter for mania mode #34774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI is failing but doesn't seem to be caused by my commits. |
|
@bdach |
bdach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess source looks fine and does what it claims to want to do
I'm going to extrapolate @peppy's thumbs up on #34774 (comment) as understanding and approval of the current limitations of this and thus I see no reason to need another approval on this
Long notes are a huge part of mania gameplay, especially with all the o2jam-style maps out there. But finding LN-heavy maps is kind of a pain since beatmap tags are often missing or wrong, and some players just want to avoid LNs entirely.
The another rhythm game Quaver has this neat LN percentage filter, so I figured why not add it to osu!mania too? Now you can filter maps by how much of them are actually long notes.
output.mp4
What's new
ln/lnskeywords to search - works with all the usual operators (=,!=,>=,>,<=,<)ln=0- maps with no long notesln>=50- maps with 50% or more long notesln<10- maps with less than 10% long notesKnown Issues
This might not work perfectly on converted beatmaps since I'm using
EndTimeObjectCountinstead of actually parsing theHitObjectsfrom theBeatmapclass. But honestly, if you're hunting for LN maps you're probably not looking at converts anyway, so it should be fine for what people actually want to do.