SongSelectV2: Fix rewind triggering on right-clicking and dragging away from random button #34704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
d6aec08 to
4a65c53
Compare
bdach
approved these changes
Aug 18, 2025
This was referenced Sep 4, 2025
This was referenced Oct 2, 2025
This was referenced Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it was an intentional change, but during the switch to Song Select V2 this check got removed from the Random button code, meaning that releasing a right click started on the random button elsewhere would always trigger rewind. This simply copies the condition over from the Song Select V1 button, making it functionally match how clicks in general work elsewhere.
Before:
2025-08-17.00-35-15.mp4
After:
2025-08-17.00-34-07.mp4