Fix even more issues with replay fail indicator #34721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
approved these changes
Aug 18, 2025
This was referenced Sep 4, 2025
This was referenced Oct 2, 2025
This was referenced Oct 9, 2025
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix replay fail indicator "go to results" button being clickable while invisible
closes #34685
Stop fail sample when rewinding to before it in replay
closes #34688
I originally wrote it this way semi-intentionally because I thought cutting out the sample was worse than letting it play out, but I also forgot that people use like seventy hour long fail samples in skins for whatever reason.
Unapply replay playback speed when going to results
closes #34700