Refresh realm before performing song select refetches following an online metadata lookup #34723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line metadata lookup Probably closes ppy#34716 Can't see any other cause, can reproduce the issue on master using manual db modifications via realm studio and it is not a consistent reproduction, so seems like an open-and-shut lack of refresh.
peppy
reviewed
Aug 18, 2025
| // which prevents working beatmap refetches caused by changes to the realm model of perceived low importance). | ||
| var status = realm.Run(r => | ||
| { | ||
| r.Refresh(); |
Member
There was a problem hiding this comment.
Important to note that refreshes will block the update thread pending all write operations, which can sometimes lead to multi-second pauses.
This is why we seldom use Refresh().
Collaborator
Author
There was a problem hiding this comment.
Aware. Unless I make the "online" beatmap set retrieval method also return the state of the database beatmap set model, there's not much room for maneuvering as far as I can tell.
Collaborator
Author
|
as per discord conversation this is apparently unacceptable due to perceived chance of resulting performance regression, closing |
Collaborator
Author
|
Reopening after extended discussion around #34737. |
peppy
approved these changes
Aug 22, 2025
This was referenced Sep 4, 2025
This was referenced Oct 2, 2025
This was referenced Oct 2, 2025
This was referenced Oct 10, 2025
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't see any other cause, can reproduce the issue on master using manual db modifications via realm studio and it is not a consistent reproduction, so seems like an open-and-shut lack of refresh.