Fix daily challenge / playlist leaderboard sometimes showing incorrect default state #34800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrong order Due to `Perform` being used from a BDL method in conjunction with `Success` (which is scheduled to the *update* thread), there was a chance that the order of execution would be not quite as intended. To rectify, let's not use `Success` and just continue with synchronous flow.
bdach
approved these changes
Aug 26, 2025
This was referenced Sep 4, 2025
This was referenced Oct 2, 2025
This was referenced Oct 9, 2025
This was referenced Oct 29, 2025
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while investigating #34641. Likely doesn't resolve that issue, but does resolve another.
The sort in 3f179e3 just feels right to have there. Avoids some edge case where it takes 1 second to show correct state on initial display.