Fix potential loss of room events during join #34819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 2, 2025
Merged
bdach
reviewed
Sep 2, 2025
peppy
reviewed
Sep 2, 2025
| return tcs.Task; | ||
| } | ||
|
|
||
| private void handleRoomRequest(Action request) |
Member
There was a problem hiding this comment.
The previous code has forceSchedule = false while the new flow doesn't, can one of you two confirm this is known and expected?
Re-reviewing this as a whole seems like it may take a bit of time so I'd rather just confirm this-is-okay and go with it.
Contributor
Author
There was a problem hiding this comment.
Earliest reference I can find is #11316. At the time the join/leave task chain didn't exist and the scheduler was relied on as an ordering mechanism, so I don't think there's much purpose to the forceSchedule these days.
This was referenced Sep 4, 2025
This was referenced Oct 2, 2025
This was referenced Oct 9, 2025
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #34815
As I mentioned internally, during
JoinRoomthere's a small window where events could be coming in and fail theRoom != nullcheck because we're busy doing a few more operations, such as looking up online users.This turns out to be more of a problem with matchmaking because all users are joined to the room simultaneously, but it can also happen in a standard multiplayer match and lead a desynchronised state.
The change here can only be classified as a hacky workaround. We'll need to do this better in the future, likely by reworking the room join process in the first place.