Fix external edit filename sanitising unintentionally dropping folder separators #34945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
reviewed
Sep 7, 2025
| // if there are further troubles related to similar issues, reevaluate moving this sort of check to the import side instead (sanitising filenames on import from archive). | ||
| string destinationPath = Path.Join(mountedPath, realmFile.Filename.GetValidFilename()); | ||
| string destinationPath = mountedPath; | ||
| foreach (string piece in realmFile.Filename.Split('/').Select(f => f.GetValidFilename())) |
There was a problem hiding this comment.
Is this guaranteed to be Unix path? In other words, is this correct to not be Path.GetFilenameSeparator() or whatever?
There was a problem hiding this comment.
The "guarantee" is here:
osu/osu.Game/Database/ModelManager.cs
Line 89 in 71210be
We could probably add an assert in RealmNamedFileUsage if that makes things more palatable.
smoogipoo
approved these changes
Sep 7, 2025
This was referenced Oct 2, 2025
This was referenced Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34929.