Fix TestDouble failing on systems where the decimal separator isn't a dot #34934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe smth can be done with this? osu/osu.Game/Rulesets/Mods/ModRateAdjust.cs Lines 30 to 37 in 014b556 |
|
@diquoks Yeah that was it. Thanks |
bdach
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue that caused TestDouble tests in NumberFormattingExtensionsTest to fail.
Note: There is still a test failing for the same reason (TestTooltip in TestSceneModIcon) which couldn't fix due to not being able to find where the conversion from number to string goes wrong.