Various improvements to matchmaking testability #35105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this will help a bit?
Most of matchmaking is intended to be tested via
TestMultiplayerClient.ChangeMatchRoomState()and designing the appropriate state to test your objects with.This change primarily adds
TestMultiplayerClient.MatchmakingChangeStage()which acts as a helper for components that just need the current stage + the countdown for it. The biggest changes are toTestSceneMatchmakingScreenandTestSceneMatchmakingScreenStack.Interspersed are a few more minor changes including 597a06a + 83dafb4 which together help to bring the room into a correct initial state, and 3556d6c which reduces the number of picks shown in test scenes to a more realistic value (8 users per room, not 50).