Make quick play redownload locally modified beatmaps #35393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
bdach
reviewed
Oct 22, 2025
Collaborator
bdach
left a comment
There was a problem hiding this comment.
For client-side non-critical beatmap availability checks this is indeed as good as it gets. The real bulwark is server-side checks on submission anyway.
bdach
previously approved these changes
Oct 23, 2025
peppy
previously approved these changes
Oct 24, 2025
peppy
approved these changes
Oct 24, 2025
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsLocallyAvailablereturnstrueif the beatmap set exists even if the beatmap we'll use was modified. The newBeatmapInfooverload added in this PR uses the same condition as in other places to test for beatmap availability:osu/osu.Game/Screens/OnlinePlay/Playlists/PlaylistsRoomSubScreen.cs
Line 612 in 47b95de
osu/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerMatchSubScreen.cs
Line 655 in 47b95de
osu/osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs
Line 493 in 47b95de
osu/osu.Game/Screens/OnlinePlay/OnlinePlayBeatmapAvailabilityTracker.cs
Lines 156 to 157 in 47b95de
For the time being, this PR only updates quick play to use this new method. Before going further and updating other usages, I'd first like confirmation that this is the correct way of going about things.