Extract all pieces of local user-related state to APIAccess subcomponent
#35415
+240
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent Something I've asked to be done for a long time. Relevant because I've complained about this on every addition of a new piece of user-local state: friends, blocks, and now favourite beatmaps. It's just so messy managing all this inside `APIAccess` next to everything else, IMO.
See, this refactor is where omissions like this that normally would pass unnoticed stop passing unnoticed.
peppy
reviewed
Oct 24, 2025
| configStatus.Value = UserStatus.Online; | ||
|
|
||
| // Scheduled prior to state change such that the state changed event is invoked with the correct user and their friends present | ||
| Schedule(() => |
There was a problem hiding this comment.
These schedules could be in a slightly different order for some operations where operations are now split across APIAccess and LocalUserState, but on a quick check I can't see this going wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Soft prereq for #34494.
This is something I've asked to be done for a long time. Relevant because I've complained about
APIAccessgetting bloated with every addition of a new piece of user-local state: friends, blocks, and now favourite beatmaps.LocalUseris left mostly unchanged due to sheer number of usages, butFriends/Blocksget the full treatment.It's just so messy managing all this inside
APIAccessnext to everything else, IMO.dfa8d4f (a bug on master, albeit of little consequence) demonstrates why I want this change.