Delay seeking the current track when dragging now playing overlay progress bar until commit #35677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gress bar until commit RFC. Written to address https://osu.ppy.sh/community/forums/topics/2150023. Few other things we might want to happen here: - pause the track when starting the drag - figure out what to do when a drag is held while the track changes in the background (which was impossible to happen before this) but I want to see the reaction to this first.
smoogipoo
approved these changes
Nov 11, 2025
Member
|
A bit of a delayed review here, but I don't quite agree with this one. At least, if we're going to do this I'd want to change the UI a bit to make it feel in line with the changed behaviour. Instead, how about we rate limit the seeks to every 200 ms or 500 ms? This should remove the weird artifacting. Stable has done this and I've not seen anyone complain about it. (also while we're here, we should probably apply the same kinda thing to editor seeks when dragging bottom timeline, as currently it has the behaviour which was fixed in this PR). |
bdach
added a commit
to bdach/osu
that referenced
this pull request
Nov 20, 2025
This was referenced Nov 21, 2025
This was referenced Dec 8, 2025
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Written to address https://osu.ppy.sh/community/forums/topics/2150023.
Few other things we might want to happen here:
but I want to see the reaction to this first.