Move realm collection writes off of update thread #35681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably closes ppy#35650. Realm slow, episode 23894. I can't reproduce freezes as big as the video in the issue is showing but 'realm slow' is 99% the culprit, because affected user's database is not small.
Contributor
|
I guess I don't hate this in principle, the pause in the video is almost exactly 10 seconds long which is why it appears to be more API related somehow. |
smoogipoo
approved these changes
Nov 11, 2025
Collaborator
Author
Well yes looking at logs again the db freeze could be exacerbated by what appears to be a flow of
but the fix for that is probably closer to ppy/osu-difficulty-calculator#241. |
This was referenced Nov 21, 2025
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably closes #35650.
Realm slow, episode 23894. I can't reproduce freezes as big as the video in the issue is showing but 'realm slow' is 99% the culprit, because affected user's database is not small.