Improve loading time of collection grouping mode #35693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supersedes / closes ppy#35687. Implements idea from ppy#35687 (comment), except without the additional record, because there's no need for it. Co-authored-by: WitherFlower <[email protected]>
Contributor
|
Have done some testing on my end au doigt mouillé and I can confirm the performance is good. I also do agree that the code is clearer and more concise here without the index hack. Great work ! I'll close the other PR. |
smoogipoo
approved these changes
Nov 13, 2025
This was referenced Nov 21, 2025
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes / closes #35687.
Implements idea from #35687 (comment), except without the additional record, because there's no need for it.
Profiling: