Fix retro skin changing when creating copy for skin editor #35630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC, lowest effort solution for ppy#34979. The `SkinImporter` conditional *is* hella ugly, but anything less ugly will require taking a hammer to structures. Maybe passing version via the import flow, maybe even trying to make the `EnsureMutableSkin()` flow somehow attempt to read the `skin.ini` that's in resources. No idea. Properties from `skin.ini` that were defaults or that lazer can't (won't ever?) understand snipped.
smoogipoo
approved these changes
Nov 6, 2025
This was referenced Nov 21, 2025
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC, lowest effort solution for #34979.
The
SkinImporterconditional is hella ugly, but anything less ugly will require taking a hammer to structures. Maybe passing version via the import flow, maybe even trying to make theEnsureMutableSkin()flow somehow attempt to read theskin.inithat's in resources. No idea.Properties from
skin.inithat were defaults or that lazer can't (won't ever?) understand snipped.