Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix cursor trail detaching from cursor when adjusting cursor scale #35802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bdach merged 9 commits into from
Dec 10, 2025
Merged

Fix cursor trail detaching from cursor when adjusting cursor scale #35802

bdach merged 9 commits into from
Dec 10, 2025
+86 −6

Conversation

@Xiragi
Copy link
Contributor

@Xiragi Xiragi commented Nov 25, 2025 •
edited by Joehuu
Loading

First PR.

Would fix #35734

I'm not sure if the tests are sufficient

@Joehuu Joehuu added ruleset/osu! area:gameplay type/cosmetic Only affects the game visually. Doesn't affect things working or not working. labels Nov 25, 2025
@bdach bdach self-requested a review November 27, 2025 09:05
bdach
bdach requested changes Nov 27, 2025
View reviewed changes
@Xiragi
Copy link
Contributor Author

Xiragi commented Nov 27, 2025

These changes should fix the cursor trail disappearing on skin change

bdach
bdach requested changes Dec 4, 2025
View reviewed changes
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 5, 2025
@Xiragi
Copy link
Contributor Author

Xiragi commented Dec 5, 2025

Implemented those change and it seems to be working as expected now. I've also simplified the test for it.

@Xiragi
Copy link
Contributor Author

Xiragi commented Dec 6, 2025

I've noticed another issue. The skin cursor trail still shows the old one during the pause menu.

  1. Hit the first note and move the cursor around to generate a trail
  2. Pause
  3. Change Skin from Classic 2013 to Argon.
  4. Unpause,
    5a. Current active cursor Skin trail, and playing normally correctly uses the new skin trail.
    5b. The trail for the play in the pause state still displays the old trail.

I'm not sure how to feel about forcing a texture update in the case that we switch between a legacy skin and a non-legacy skin. And at the same time, I feel like the PR is moving far from what it was intending to fix.

@bdach bdach changed the title Move LocalSpacePosition calculation until the time of render Fix cursor trail detaching from cursor when adjusting cursor scale Dec 9, 2025
@bdach
Copy link
Collaborator

bdach commented Dec 9, 2025

The skin cursor trail still shows the old one during the pause menu.

Out of scope, tracked separately at #7285.

@bdach bdach merged commit e68bab4 into ppy:master Dec 10, 2025
9 checks passed
@kyiuu1 kyiuu1 mentioned this pull request Dec 18, 2025
Closed
bdach added a commit to bdach/osu that referenced this pull request Dec 19, 2025
@bdach
Fix cursor scale affecting trail spacing
e094eef 
Closes ppy#36061.

Regressed in ppy#35802.

It's either this or revert of aforementioned pull. I dunno.
@bdach bdach mentioned this pull request Dec 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdach bdach bdach approved these changes

Assignees

No one assigned

Labels

area:gameplay ruleset/osu! size/M type/cosmetic Only affects the game visually. Doesn't affect things working or not working.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The cursor trail moves if you change cursor size during a pause

3 participants

@Xiragi @bdach @Joehuu