Switch ruleset in SongSelectV2 when needed #35996
Conversation
| checkAndApplyRuleset(); | ||
|
|
||
| ensureGlobalBeatmapValid(); |
There was a problem hiding this comment.
I don't know about any of this.
This is approaching too many levels of adjustments. Previously a global change happening was handled pretty simply: check if it's valid selection for song select, and if not, choose something else valid. But this? Now with this it's
- when receiving an external beatmap change, maybe change the external beatmap to something else again, or maybe change the ruleset to a different one
- and then immediately after doing that validate the selection that you just potentially modified
Like which one is it? Is external selection going to impose state of song select, or is it going to yield selection validity to song select? You can't have it both ways.
@peppy would want you to look at this as well and express your view.
| // try to find a beatmap whose ruleset is current. | ||
| var beatmapWithinCurrentRuleset = Beatmap.Value.BeatmapSetInfo.Beatmaps.FirstOrDefault(b => b.Ruleset.Equals(Ruleset.Value)); |
There was a problem hiding this comment.
does not appear to take converts into account
|
|
||
| if (beatmapWithinCurrentRuleset != null) | ||
| { | ||
| Beatmap.Value = beatmaps.GetWorkingBeatmap(beatmapWithinCurrentRuleset); |
There was a problem hiding this comment.
why does this unconditionally touch the global beatmap again? inside a global beatmap change callback? that's recursive. why doesn't it only perform the change when necessary?
| debounceQueueSelection(groupedBeatmap.Beatmap); | ||
| } | ||
|
|
||
| private bool checkAndApplyRuleset() |
There was a problem hiding this comment.
why does this have a return value if it's never checked?
Like SongSelectV1, when current beatmapset is changed from outside (like playlist) and the beatmap isn't in line with the current ruleset, switch to the new ruleset (or beatmaps whose ruleset is current).
2025-12-14.16-11-50-cut.mp4