Add ability to view other beatmaps in set when difficulties are split apart #36047
Conversation
… apart First part of ppy#36039, see also ppy#33784. The goal is to add this back to the set panels too, but that one is more complicated than this if you can believe it (because it requires being able to tell which other difficulties of the set are filtered out to fade them out). I also foresee the display logic to vary significantly there. Of note, for this to work in beatmaps-split-apart mode, this requires a change of behaviour in the filtering logic. Old song select when given a "selected beatmap set" would *include* that in results regardless of the filter, but that doesn't work for beatmaps-split-apart for reasons that are hopefully obvious, so this changes the behaviour to *entirely bypass* the filter and just show the set. Unsure how angry will people be with that. Also of note, when in the scoped mode, altering any filter criteria will dismiss the scope.
|
Input handling edge case: osu.2025-12-18.at.13.10.08.mp4Also, after clicking successfully, it seems like all the little difficulty markers disappear briefly: osu.2025-12-18.at.13.11.46.mp4 |
that'll be a failing of
is that frame by frame playback? how am I supposed to check this? |
|
I wonder if we should force the beatmap set display into grouped mode (ie. temporarily turn off user sort/group modes). This would allow showing the set header (which also allows operations like deleting the full beatmap set, people have trouble finding this so giving them one other method of doing so would not hurt IMO). |
I think the best way is to make the button itself (either visibly or virtually) larger. I was going to mention that it's a very small hit target already, so increasing the size will probably solve two issues. A good starting point would be to match the height of the pill to the left. It's a small adjustment but should help considerably: That said, even if it's an
I was seeking through a video yes, but it's very obvious to me in realtime too. |
|
One more thing: Escape works to exit this display mode, but if you have an active search it also clears that. I don't think the first escape press should clear the search from the textbox in such a case. |
b4b74dd to
4cce6aa
Compare
I have no strong opinion on this so I'm leaving it be as-is unless I get told to change it. |
Screen.Recording.2025-12-17.at.12.22.00.mov
First part of #36039, see also #33784.
The goal is to add this back to the set panels too, but that one is more complicated than this if you can believe it (because it requires being able to tell which other difficulties of the set are filtered out to fade them out which is not super easy given new song select structure). I also foresee the display logic to vary significantly there.
Of note, for this to work in beatmaps-split-apart mode, this requires a change of behaviour in the filtering logic. Old song select when given a "selected beatmap set" would include that in results regardless of the filter, but that doesn't work for beatmaps-split-apart for reasons that are hopefully obvious, so this changes the behaviour to entirely bypass the filter and just show the set. Unsure how angry will people be with that.
Also of note, when in the scoped mode, altering any filter criteria will dismiss the scope.