Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@frenzibyte
Copy link
Member

As per #35959 (comment), this is a "bandaid" fix which makes the skip overlay resilient to any unexpected clock states.

There's no way to write a test for this, but I've tested it manually through this diff just for sanity:

diff --git a/osu.Game/Screens/Play/SkipOverlay.cs b/osu.Game/Screens/Play/SkipOverlay.cs
index f9752706ad..3d9564db48 100644
--- a/osu.Game/Screens/Play/SkipOverlay.cs
+++ b/osu.Game/Screens/Play/SkipOverlay.cs
@@ -180,6 +180,8 @@ void attemptNextSkip() => Scheduler.AddDelayed(() =>
             }, 200);
         }
 
+        private bool first = true;
+
         protected override void Update()
         {
             base.Update();
@@ -193,7 +195,9 @@ protected override void Update()
 
             RemainingTimeBox.Width = (float)Interpolation.Lerp(RemainingTimeBox.Width, progress, Math.Clamp(Time.Elapsed / 40, 0, 1));
 
-            inSkipPeriod.Value = progress > 0;
+            inSkipPeriod.Value = !first && progress > 0;
+            first = false;
+
             buttonContainer.State.Value = inSkipPeriod.Value ? Visibility.Visible : Visibility.Hidden;
         }
 

@frenzibyte frenzibyte added area:gameplay type/behavioural An issue with actual UI or game behaviour. Has a real world impact causing something to not work. labels Dec 15, 2025
@bdach bdach moved this from Inbox to Pending Review in osu! untitled project Dec 16, 2025
@bdach bdach self-requested a review December 16, 2025 13:31
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am lacking brighter ideas

@bdach bdach merged commit 74ca87c into ppy:master Dec 16, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Pending Review to Done in osu! untitled project Dec 16, 2025
@frenzibyte frenzibyte deleted the fix-skip-button branch December 16, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:gameplay size/M type/behavioural An issue with actual UI or game behaviour. Has a real world impact causing something to not work.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Skip button stops working after retry

2 participants